Skip to content

[operators][integrate]fix: Add assignmentOperationExpr in ExprStatement #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2020
Merged

[operators][integrate]fix: Add assignmentOperationExpr in ExprStatement #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7511fd2
Add assignment expr in exprStatement
summer-ji-eng Oct 1, 2020
d6dfb9b
Merge branch 'master' into add_expr_statement
summer-ji-eng Oct 2, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/google/api/generator/engine/ast/ExprStatement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ public ExprStatement build() {
(expr instanceof MethodInvocationExpr)
|| (expr instanceof ReferenceConstructorExpr)
|| (expr instanceof AssignmentExpr)
|| (expr instanceof AssignmentOperationExpr)
|| (expr instanceof ThrowExpr)
|| (expr instanceof ReturnExpr)
|| (expr instanceof UnaryOperationExpr
Expand Down
9 changes: 9 additions & 0 deletions src/test/java/com/google/api/generator/engine/ast/ExprStatementTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,15 @@ public void validExprStatement_unaryOperation() {
Variable.builder().setType(TypeNode.INT).setName("i").build())));
}

@Test
public void validExprStatement_assignmentOperationExpr() {
VariableExpr lhsExpr =
VariableExpr.withVariable(Variable.builder().setName("i").setType(TypeNode.INT).build());
ValueExpr rhsExpr =
ValueExpr.withValue(PrimitiveValue.builder().setValue("5").setType(TypeNode.INT).build());
assertValidExprStatement(AssignmentOperationExpr.multiplyAssignmentWithExprs(lhsExpr, rhsExpr));
}

@Test
public void invalidExprStatement_variable() {
Variable variable = Variable.builder().setType(TypeNode.INT).setName("libraryClient").build();
Expand Down