- Notifications
You must be signed in to change notification settings - Fork 68
deps: Bump grpc-java to v1.76.0 #3942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @lqiu96, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| /gcbrun |
| Enforcer: Looks like I'll need to bump guava in sdk-platform-java |
mpeddada1 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah looks like the enforcer check is failing:
Require upper bound dependencies error for com.google.guava:guava:33.4.0-jre paths to dependency are: Error: +-com.google.api.grpc:grpc-google-common-protos:2.61.4-SNAPSHOT Error: +-com.google.guava:guava:33.4.0-jre Error: and Error: +-com.google.api.grpc:grpc-google-common-protos:2.61.4-SNAPSHOT Error: +-io.grpc:grpc-api:1.76.0 Error: +-com.google.guava:guava:33.4.0-jre [runtime] (managed) <- There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the grpc-java dependency from version 1.71.0 to 1.76.0. The version is updated in the parent pom.xml, which is the correct approach for managing dependency versions consistently across the project. The change is straightforward and looks good.
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [com.google.auth:google-auth-library-credentials](https://redirect.github.com/googleapis/google-auth-library-java) | `1.39.1` -> `1.40.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.google.auth:google-auth-library-oauth2-http](https://redirect.github.com/googleapis/google-auth-library-java) | `1.39.1` -> `1.40.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [com.google.auth:google-auth-library-bom](https://redirect.github.com/googleapis/google-auth-library-java) | `1.39.1` -> `1.40.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- <details> <summary>googleapis/google-auth-library-java (com.google.auth:google-auth-library-credentials)</summary> [`v1.40.0`](https://redirect.github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#1400-2025-10-14) [Compare Source](https://redirect.github.com/googleapis/google-auth-library-java/compare/v1.39.1...v1.40.0) - Add projectId getter to GoogleCredentials ([#​1813](https://redirect.github.com/googleapis/google-auth-library-java/issues/1813)) ([c3d9ee0](https://redirect.github.com/googleapis/google-auth-library-java/commit/c3d9ee09df30a26586b0e834cfda7763fd7854f5)) - Support user defined or json defined scopes for impersonated token ([#​1815](https://redirect.github.com/googleapis/google-auth-library-java/issues/1815)) ([84fc566](https://redirect.github.com/googleapis/google-auth-library-java/commit/84fc566d92f03e648cd82a8860fb191520bb6c7e)) - Bump guava to v33.5.0 ([#​1825](https://redirect.github.com/googleapis/google-auth-library-java/issues/1825)) ([79f0a35](https://redirect.github.com/googleapis/google-auth-library-java/commit/79f0a353e12a8206584e9031989861ca6abaaf85)) </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/googleapis/sdk-platform-java). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE0My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
Update to the `chore:` type so it doesn't show up in the release notes
| Error: |
| Going to mark this as Will figure out a direction once we coordinate with the gRPC folks. |
After some discussions, we are fine with upgrading to grpc-java v1.76.0. Merging this in for the next release cycle. |
| /gcbrun |
| /gcbrun |
1 similar comment
| /gcbrun |
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE | ||
| + "org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerIndexField", | ||
| "producerIndex"); | ||
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE | ||
| + "org.jctools.queues.unpadded.MpscUnpaddedArrayQueueProducerLimitField", | ||
| "producerLimit"); | ||
| registerForUnsafeFieldAccess( | ||
| access, | ||
| NETTY_SHADED_PACKAGE | ||
| + "org.jctools.queues.unpadded.MpscUnpaddedArrayQueueConsumerIndexField", | ||
| "consumerIndex"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are essentially copies of the padded versions of above Mpsc classes. I think it's possible just to replace the padded above since new version of netty shaded within gRPC doesn't call the padded variant anymore.
I have kept both padded and unpadded for now as I don't know the impact if I just replace it. I don't think there is any harm is "overregistering" for GraalVM but can remove if there is.
diegomarquezp left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a minor question and nit. Thanks for the upgrade.
| * [Location.metadata][google.cloud.location.Location.metadata] field. | ||
| * </pre> | ||
| */ | ||
| @javax.annotation.Generated( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think everything here comes strictly from grpc-gen, right? Otherwise I wonder if some postprocessing step stopped adding this annotation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is from grpc gen code. grpc/grpc-java@f8700a1
| grpc_java_repositories() | ||
| | ||
| load("@envoy_api//bazel:repositories.bzl", "api_dependencies") | ||
| load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: would it make sense to add a quick explainer on how grpc needs this and maybe reference grpc/grpc-java#12243?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments above about the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the WORKSPACE file in googleapis needs this change as well, can we follow up on that once this change is released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! That is the plan!
|
|
🤖 I have created a release *beep* *boop* --- <details><summary>2.64.0</summary> ## [2.64.0](v2.63.0...v2.64.0) (2025-10-31) ### Features * [common-protos] Add `Carousel` widget ([1e4a7e5](1e4a7e5)) * **librariangen:** add generate package ([#3952](#3952)) ([2f6c75d](2f6c75d)) * **librariangen:** generate grpc stubs and resource helpers ([#3967](#3967)) ([452d703](452d703)) ### Dependencies * Bump grpc-java to v1.76.0 ([#3942](#3942)) ([ffb557c](ffb557c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
With the [recent upgrade of grpc](#3942), the transitive dependency on `opentelemetry-api` was bumped to 1.52.0 as per grpc/grpc-java@f30964a. In order to prevent upper bound dependency warnings (as in googleapis/java-storage#3381), we update opentelemetry.version to 1.52.0




This PR bumps the gRPC gen code and runtime versions from
v1.71.0tov1.76.0.StatusExceptionthat users will need to catch. This was part of gRPC 1.74.0 (compiler: generate blocking v2 unary calls that throw StatusException grpc/grpc-java#12126)Changes
bazel_jar_jaras part of this PR (bazel: Use jarjar to avoid xds deps grpc/grpc-java#12243) in gRPC-Java v1.75.0