- Notifications
You must be signed in to change notification settings - Fork 86
deps: update dependency com.google.cloud:sdk-platform-java-config to v3.54.1 #3381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update dependency com.google.cloud:sdk-platform-java-config to v3.54.1 #3381
Conversation
| /gcbrun |
| Blocked on |
| /gcbrun |
| Deleting the cache of these CI jobs. |
| /gcbrun |
Thanks @BenWhitehead for looking into this. I have raised googleapis/sdk-platform-java#3979, which solves this upper bound problem by bumping opentelemetry.version to 1.52.0. |
| Thanks @diegomarquezp! |
With the [recent upgrade of grpc](#3942), the transitive dependency on `opentelemetry-api` was bumped to 1.52.0 as per grpc/grpc-java@f30964a. In order to prevent upper bound dependency warnings (as in googleapis/java-storage#3381), we update opentelemetry.version to 1.52.0
5a191b9 to 7c62a92 Compare | /gcbrun |
| /gcbrun |
| { "name": "io.grpc.xds.shaded.com.github.udpa.udpa.type.v1.TypedStruct$Builder", "queryAllDeclaredConstructors": true, "queryAllPublicConstructors": true, "queryAllDeclaredMethods": true, "allPublicMethods": true, "allDeclaredClasses": true, "allPublicClasses": true }, | ||
| { "name": "io.grpc.xds.shaded.com.github.xds.core.v3.Authority", "queryAllDeclaredConstructors": true, "queryAllPublicConstructors": true, "queryAllDeclaredMethods": true, "allPublicMethods": true, "allDeclaredClasses": true, "allPublicClasses": true }, | ||
| { "name": "io.grpc.xds.shaded.com.github.xds.core.v3.Authority$Builder", "queryAllDeclaredConstructors": true, "queryAllPublicConstructors": true, "queryAllDeclaredMethods": true, "allPublicMethods": true, "allDeclaredClasses": true, "allPublicClasses": true }, | ||
| { "name": "io.grpc.xds.shaded.com.github.xds.core.v3.CidrRange", "queryAllDeclaredConstructors": true, "queryAllPublicConstructors": true, "queryAllDeclaredMethods": true, "allPublicMethods": true, "allDeclaredClasses": true, "allPublicClasses": true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this codepath is triggered in storage only but not in gax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's triggered by directpath being available for gcs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've had to move this kind of configurations upstream in recent GraalVM migrations.
| "methods":[{"name":"<init>","parameterTypes":[] }] | ||
| }, | ||
| { "name": "com.google.protobuf.Message$Builder", "queryAllDeclaredConstructors": true, "queryAllPublicConstructors": true, "queryAllDeclaredMethods": true, "allPublicMethods": true, "allDeclaredClasses": true, "allPublicClasses": true }, | ||
| { "name": "com.google.protobuf.GeneratedMessageV3", "queryAllDeclaredConstructors": true, "queryAllPublicConstructors": true, "queryAllDeclaredMethods": true, "allPublicMethods": true, "allDeclaredClasses": true, "allPublicClasses": true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is somewhat alarming, are the protobuf changes required? I don't see GeneratedMessageV3 being used explicitly in grpc-java, and usually we should use the interface directly for stability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is one of the classes found by classgraph when analyzing the grpc classes for protobuf classes. we're not depending on this class, simply including it as one that native-image needs to load.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This PR contains the following updates:
3.53.0->3.54.1Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.