Skip to content

docs: add clarifications to read timeout #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 4, 2023
Merged

docs: add clarifications to read timeout #873

merged 6 commits into from
Jan 4, 2023

Conversation

@cojenco
Copy link
Contributor

@cojenco cojenco commented Sep 26, 2022

Clarify timeout definition and usage, especially on read timeout

  • read timeout is the number of seconds the client will wait for the server to send a response.
    In most cases, this is the maximum wait time before the server sends the first byte.
  • connect timeout is the number of seconds to establish a connection to the server

Fixes internal b/238779055
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Sep 26, 2022
@cojenco cojenco marked this pull request as ready for review September 26, 2022 20:20
@cojenco cojenco requested review from a team as code owners September 26, 2022 20:20
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 26, 2022
@cojenco cojenco requested a review from andrewsg September 28, 2022 17:22
andrewsg
andrewsg requested changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this information accurate for non-media API calls as well as media calls? I remember there being some nuance there even though both of them boil down to the requests library.
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 27, 2022
@cojenco cojenco requested a review from andrewsg December 27, 2022 21:41
@cojenco cojenco added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 4, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 8fb26f4 into googleapis:main Jan 4, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 4, 2023
@release-please release-please bot mentioned this pull request Jan 4, 2023
Merged
@cojenco cojenco deleted the docs-timeout branch November 16, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.

2 participants

@cojenco @andrewsg