Skip to content

Conversation

IlyaFaer
Copy link
Contributor

@IlyaFaer IlyaFaer commented May 17, 2021

A PeekIterator object (used by Cursor as a wrapper around the results iterator) does a preliminary stream of the first resulting row (to get the metadata of the response itself). In such a case, if an Aborted exception happened, it'll not be retried - fixing this error.

Fixes #342

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label May 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 17, 2021
@IlyaFaer IlyaFaer marked this pull request as ready for review May 17, 2021 09:18
@IlyaFaer IlyaFaer requested a review from a team as a code owner May 17, 2021 09:18
@IlyaFaer IlyaFaer requested a review from larkee May 18, 2021 07:51
@larkee larkee changed the title fix: an Aborted exception isn't properly retried fix: try Aborted errors when creating PeekIterator May 18, 2021
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@larkee larkee changed the title fix: try Aborted errors when creating PeekIterator fix: retry Aborted errors when creating PeekIterator May 18, 2021
@larkee larkee merged commit e69e6ab into googleapis:master May 18, 2021
@IlyaFaer IlyaFaer deleted the retry_aborted branch May 18, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

2 participants