Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

Commit 494f3f6

Browse files
feat: Tune Secret Manager auto retry parameters (#144)
UNKNOWN removed from retryable errors per AIP-194. Added RESOURCE_EXHAUSTED with adjusted parameters for better performance with spikes of AccessSecretVersion requests at or near quota limits. PiperOrigin-RevId: 383886699 Source-Link: googleapis/googleapis@1eade81 Source-Link: https://github.com/googleapis/googleapis-gen/commit/090b0f7df47c003b8aa2871830f480f4543c2ee4
1 parent 47cdda9 commit 494f3f6

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

google/cloud/secretmanager_v1/services/secret_manager_service/async_client.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -919,11 +919,12 @@ async def access_secret_version(
919919
rpc = gapic_v1.method_async.wrap_method(
920920
self._client._transport.access_secret_version,
921921
default_retry=retries.Retry(
922-
initial=1.0,
922+
initial=2.0,
923923
maximum=60.0,
924-
multiplier=1.3,
924+
multiplier=2.0,
925925
predicate=retries.if_exception_type(
926-
core_exceptions.ServiceUnavailable, core_exceptions.Unknown,
926+
core_exceptions.ResourceExhausted,
927+
core_exceptions.ServiceUnavailable,
927928
),
928929
deadline=60.0,
929930
),

google/cloud/secretmanager_v1/services/secret_manager_service/transports/base.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,11 +187,12 @@ def _prep_wrapped_messages(self, client_info):
187187
self.access_secret_version: gapic_v1.method.wrap_method(
188188
self.access_secret_version,
189189
default_retry=retries.Retry(
190-
initial=1.0,
190+
initial=2.0,
191191
maximum=60.0,
192-
multiplier=1.3,
192+
multiplier=2.0,
193193
predicate=retries.if_exception_type(
194-
core_exceptions.ServiceUnavailable, core_exceptions.Unknown,
194+
core_exceptions.ResourceExhausted,
195+
core_exceptions.ServiceUnavailable,
195196
),
196197
deadline=60.0,
197198
),

0 commit comments

Comments
 (0)