fix: disable always_use_jwt_access (#143)

Committer: @busunkim96 PiperOrigin-RevId: 382142900 Source-Link: googleapis/googleapis@513440f Source-Link: https://github.com/googleapis/googleapis-gen/commit/7b1e2c31233f79a704ec21ca410bf661d6bc68d0

Author: gcf-owl-bot[bot]

google/cloud/secretmanager_v1/services/secret_manager_service/transports/base.py

@@ -102,7 +102,7 @@ def __init__(
  scopes_kwargs = self._get_scopes_kwargs(self._host, scopes)
 
  # Save the scopes.
- self._scopes = scopes or self.AUTH_SCOPES
+ self._scopes = scopes
 
  # If no credentials are provided, then determine the appropriate
  # defaults.

google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc.py

@@ -67,6 +67,7 @@ def __init__(
  client_cert_source_for_mtls: Callable[[], Tuple[bytes, bytes]] = None,
  quota_project_id: Optional[str] = None,
  client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO,
+ always_use_jwt_access: Optional[bool] = False,
  ) -> None:
  """Instantiate the transport.
 
@@ -107,6 +108,8 @@ def __init__(
  API requests. If ``None``, then default info will be used.
  Generally, you only need to set this if you're developing
  your own client library.
+ always_use_jwt_access (Optional[bool]): Whether self signed JWT should
+ be used for service account credentials.
 
  Raises:
  google.auth.exceptions.MutualTLSChannelError: If mutual TLS transport
@@ -159,7 +162,7 @@ def __init__(
  scopes=scopes,
  quota_project_id=quota_project_id,
  client_info=client_info,
- always_use_jwt_access=True,
+ always_use_jwt_access=always_use_jwt_access,
  )
 
  if not self._grpc_channel:

google/cloud/secretmanager_v1/services/secret_manager_service/transports/grpc_asyncio.py

@@ -113,6 +113,7 @@ def __init__(
  client_cert_source_for_mtls: Callable[[], Tuple[bytes, bytes]] = None,
  quota_project_id=None,
  client_info: gapic_v1.client_info.ClientInfo = DEFAULT_CLIENT_INFO,
+ always_use_jwt_access: Optional[bool] = False,
  ) -> None:
  """Instantiate the transport.
 
@@ -154,6 +155,8 @@ def __init__(
  API requests. If ``None``, then default info will be used.
  Generally, you only need to set this if you're developing
  your own client library.
+ always_use_jwt_access (Optional[bool]): Whether self signed JWT should
+ be used for service account credentials.
 
  Raises:
  google.auth.exceptions.MutualTlsChannelError: If mutual TLS transport
@@ -205,7 +208,7 @@ def __init__(
  scopes=scopes,
  quota_project_id=quota_project_id,
  client_info=client_info,
- always_use_jwt_access=True,
+ always_use_jwt_access=always_use_jwt_access,
  )
 
  if not self._grpc_channel:

tests/unit/gapic/secretmanager_v1/test_secret_manager_service.py

@@ -140,7 +140,25 @@ def test_secret_manager_service_client_service_account_always_use_jwt(client_cla
  ) as use_jwt:
  creds = service_account.Credentials(None, None, None)
  client = client_class(credentials=creds)
- use_jwt.assert_called_with(True)
+ use_jwt.assert_not_called()
+
+
+@pytest.mark.parametrize(
+ "transport_class,transport_name",
+ [
+ (transports.SecretManagerServiceGrpcTransport, "grpc"),
+ (transports.SecretManagerServiceGrpcAsyncIOTransport, "grpc_asyncio"),
+ ],
+)
+def test_secret_manager_service_client_service_account_always_use_jwt_true(
+ transport_class, transport_name
+):
+ with mock.patch.object(
+ service_account.Credentials, "with_always_use_jwt_access", create=True
+ ) as use_jwt:
+ creds = service_account.Credentials(None, None, None)
+ transport = transport_class(credentials=creds, always_use_jwt_access=True)
+ use_jwt.assert_called_once_with(True)
 
 
 @pytest.mark.parametrize(
@@ -4263,7 +4281,7 @@ def test_secret_manager_service_grpc_transport_client_cert_source_for_mtls(
  "squid.clam.whelk:443",
  credentials=cred,
  credentials_file=None,
- scopes=("https://www.googleapis.com/auth/cloud-platform",),
+ scopes=None,
  ssl_credentials=mock_ssl_channel_creds,
  quota_project_id=None,
  options=[
@@ -4372,7 +4390,7 @@ def test_secret_manager_service_transport_channel_mtls_with_client_cert_source(
  "mtls.squid.clam.whelk:443",
  credentials=cred,
  credentials_file=None,
- scopes=("https://www.googleapis.com/auth/cloud-platform",),
+ scopes=None,
  ssl_credentials=mock_ssl_cred,
  quota_project_id=None,
  options=[
@@ -4419,7 +4437,7 @@ def test_secret_manager_service_transport_channel_mtls_with_adc(transport_class)
  "mtls.squid.clam.whelk:443",
  credentials=mock_cred,
  credentials_file=None,
- scopes=("https://www.googleapis.com/auth/cloud-platform",),
+ scopes=None,
  ssl_credentials=mock_ssl_cred,
  quota_project_id=None,
  options=[