Skip to content

fix: Don't leave a bad future in place when client creation fails #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022
Merged

fix: Don't leave a bad future in place when client creation fails #362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion google/cloud/pubsublite/cloudpubsub/internal/client_multiplexer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,13 @@ def __init__(
async def get_or_create(self, key: _Key) -> _Client:
if key not in self._live_clients:
self._live_clients[key] = asyncio.ensure_future(self._factory(key))
return await self._live_clients[key]
future = self._live_clients[key]
try:
return await future
except BaseException as e:
if key in self._live_clients and self._live_clients[key] is future:
del self._live_clients[key]
raise e

async def try_erase(self, key: _Key, client: _Client):
if key not in self._live_clients:
Expand Down