Skip to content

fix: allow protobuf 6.x, allow redis 6.x #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
parthea merged 10 commits into from
Jun 11, 2025
Merged

fix: allow protobuf 6.x, allow redis 6.x #1013

parthea merged 10 commits into from
Jun 11, 2025

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 15, 2025 •
edited
Loading

This PR includes the following changes

  • Removes unused scripts/configurations in .kokoro
  • Adds testing for Python 3.13
  • Allows protobuf 6.x
  • Allows redis 6.x

Fixes #1017
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Mar 15, 2025
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2025
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 17, 2025
@parthea
Copy link
Contributor Author

parthea commented Mar 18, 2025

4 tests failing

=========================== short test summary info ============================ FAILED tests/system/test_crud.py::test_compressed_repeated_local_structured_property[] FAILED tests/system/test_crud.py::test_compressed_repeated_local_structured_property[system-tests-named-db] FAILED tests/system/test_misc.py::test_legacy_local_structured_property_with_boolean[] FAILED tests/system/test_misc.py::test_legacy_local_structured_property_with_boolean[system-tests-named-db]
@parthea parthea changed the title fix: Allow Protobuf 6.x fix: allow protobuf 6.x, allow redis 6.x Jun 11, 2025
@parthea parthea marked this pull request as ready for review June 11, 2025 11:18
@parthea parthea requested review from a team as code owners June 11, 2025 11:18
@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 11, 2025
@parthea parthea requested review from gkevinzheng and rwhogg June 11, 2025 11:24
rwhogg
rwhogg reviewed Jun 11, 2025
View reviewed changes
noxfile.py Outdated
NOX_DIR = os.path.abspath(os.path.dirname(__file__))
DEFAULT_INTERPRETER = "3.8"
ALL_INTERPRETERS = ("3.7", "3.8", "3.9", "3.10", "3.11", "3.12")
ALL_INTERPRETERS = ("3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.13")
Copy link
Contributor

@rwhogg rwhogg Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is 3.13 there twice?
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jun 11, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2025
@parthea parthea enabled auto-merge (squash) June 11, 2025 15:38
@parthea parthea merged commit b3684fe into main Jun 11, 2025
6 checks passed
@parthea parthea deleted the allow-protobuf-6 branch June 11, 2025 16:02
@release-please release-please bot mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the googleapis/python-ndb API.

4 participants

@parthea @rwhogg @yoshi-kokoro @gkevinzheng