feat!: use microgenerator #92
Conversation
Change-Id: I67e149dc43ebdb11144ac3839e062aa4668ebb2e
Change-Id: I866edcc956fda2265dd7af7b774336930ec6a151
Change-Id: Ieaf7237fc6f925daec46a07d2e81a452b841198a
* Add tests for quickstarts * Update secrets
…samples#887) * Remove cloud config fixture * Fix client secrets * Fix bigtable instance
…mples#914) * Auto-update dependencies. * xfail the error reporting test * Fix lint
…#962) * Fix README rst links * Update all READMEs
…amples#1004) * Auto-update dependencies. * Fix natural language samples * Fix pubsub iam samples * Fix language samples * Fix bigquery samples
…amples#1055) * Auto-update dependencies. * Explicitly use latest bigtable client Change-Id: Id71e9e768f020730e4ca9514a0d7ebaa794e7d9e * Revert language update for now Change-Id: I8867f154e9a5aae00d0047c9caf880e5e8f50c53 * Remove pdb. smh Change-Id: I5ff905fadc026eebbcd45512d4e76e003e3b2b43
Change-Id: I6691c70912b1e1b5993e962a4827a846642feac3
…amples#1093) * Auto-update dependencies. * Fix storage notification poll sample Change-Id: I6afbc79d15e050531555e4c8e51066996717a0f3 * Fix spanner samples Change-Id: I40069222c60d57e8f3d3878167591af9130895cb * Drop coverage because it's not useful Change-Id: Iae399a7083d7866c3c7b9162d0de244fbff8b522 * Try again to fix flaky logging test Change-Id: I6225c074701970c17c426677ef1935bb6d7e36b4
…atform/python-docs-samples#1121) Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2
…-docs-samples#1158) * Update Readme.rst to add Python setup guide As requested in b/64770713. This sample is linked in documentation https://cloud.google.com/bigtable/docs/scaling, and it would make more sense to update the guide here than in the documentation. * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update README.rst * Update install_deps.tmpl.rst * Updated readmegen scripts and re-generated related README files * Fixed the lint error
Change-Id: I0d420f3053f391fa225e4b8179e45fd1138f5c65
GoogleCloudPlatform/python-docs-samples#1233) * Add sample for standard library logging handler configuration * Add handler.py to readme
…amples#1377) * Auto-update dependencies. * Update requirements.txt
google-cla bot added the cla: no 
| We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
snippet-bot bot removed the snippet-bot:force-run 
| Here is the summary of changes. You added 10 region tags.
This comment is generated by snippet-bot. |
| @daniel-sanche This is now ready for review. |
| We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
UPGRADING.md Outdated
| | ||
| > **WARNING**: Breaking change | ||
| The generated client is no longer exposed at `logging_v2`. |
There was a problem hiding this comment.
It might be good to mention why here. Maybe link to the API docs for the hand-written layer?
UPGRADING.md Outdated
| | ||
| > **WARNING**: Breaking change | ||
| Methods expect request objects. We provide a script that will convert most common use cases. |
There was a problem hiding this comment.
This should only affect users using the gapic layer, right?
There was a problem hiding this comment.
Yep, I'll add another note to make that more clear.
UPGRADING.md Outdated
| ``` | ||
| | ||
| | ||
| **Before** |
There was a problem hiding this comment.
Is this supposed to be **After**?
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2019 Google LLC. | |||
There was a problem hiding this comment.
I think this is something we'd have to fix in googleapis. See googleapis/googleapis@64ab974
| We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
| We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
busunkim96 added cla: yes The bulk of the changes are to the handwritten code (`gogle/cloud/logging_v2/*.py`). Changes are listed in `UPGRADING.md`. * `_gapic` uses the microgenerated surface * Add support for parent resources that are not `project` (`folder`, `billingAccount`, `organization`) where appropriate for log entries and sinks. * Use google-style docstrings * Optional params can only be passed as kwargs
The bulk of the changes are to the handwritten code (
gogle/cloud/logging_v2/*.py). Changes are listed inUPGRADING.md._gapicuses the microgenerated surfaceproject(folder,billingAccount,organization) where appropriate for log entries and sinks.