feat!: support string-encoded json #339
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We recently merged a PR into the v3.0.0 staging branch adding support for logging dicts as jsonPayload logs in our custom handlers:
While this can be useful in basic logging set-ups, the Python logging API expects string-like msg inputs, so this can't always be relied on to work properly in more complex logging environments.
With this PR, the handlers will also attempt to parse a dictionary out of the final log string before sending it on Cloud Logging, so string-encoded dictionaries will work as expected:
This also allows you to set a formatter object with logging attributes once, and then continue to log strings as normal. Each log will now show up in jsonPayload format in CloudLogging
You can also specify in custom fields using the
extra
argument:Fixes #331