Update table_insert_rows.py #253
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adding information to this example for more efficient streaming. Reduce calls to client.get_table()
google-cla bot added the cla: yes 
product-auto-label bot added the api: bigquery 
plamut suggested changes Sep 1, 2020
There was a problem hiding this comment.
On the surface the change seems sensible, although I cannot really comment on the wording in the comments, as I'm not a native English speaker.
Before merging, though, please make sure that the all the checks pass (linters, tests...), and that commit messages follow the conventional commits guideline, thanks!
| if errors == []: | ||
| try: | ||
| # Stream data to BQ | ||
| client.insert_rows(table_id, selected_fields=schema, rows_to_insert) |
There was a problem hiding this comment.
Positional arguments cannot follow keyword arguments, please change the call.
There was a problem hiding this comment.
Also, still need to check for errors. The API call returns success on parial failure, such as unable to insert a particular row.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adding information to this example for more efficient streaming. Reduce calls to client.get_table()
This PR is meant to replace #212 due to issues from referencing a release initially. Comments and suggestions were incorporated into this PR.
Fixes #211 🦕