refactor: Extract out common logic from Tensorboard BatchedRequestSender into a base class. #592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
product-auto-label bot added the api: aiplatform 
yfang1 changed the title yfang1 changed the title 
sasha-gitg approved these changes Aug 6, 2021
Member
sasha-gitg left a comment
sasha-gitg left a comment There was a problem hiding this comment.
LGTM. Left a few comments. Thanks!
…der into a base class.
sasha-gitg added the automerge 
vinnysenthil approved these changes Aug 6, 2021
gcf-merge-on-green bot removed the automerge Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Exacted out common logic from the 3 BatchedRequestSenders into a base class.
This will facilitate optimizations down the road.
As nice side effects this brings up the uploader's test coverage due to fewer lines of code, and allows blob references to be batched instead of sent one at a time.
unit test passed. Tried uploading all 3 types of data. Working well.