fix: remove model_display_name requirement for training jobs #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added the api: aiplatform 
google-cla bot added the cla: yes 
morgandu requested review from sasha-gitg and vinnysenthil and removed request for sasha-gitg 
sasha-gitg approved these changes Apr 16, 2021
| ) | ||
| | ||
| if self._managed_model.container_spec.image_uri: | ||
| model_display_name = model_display_name or self._display_name |
There was a problem hiding this comment.
Suggested change
| model_display_name = model_display_name or self._display_name | |
| model_display_name = model_display_name or self._display_name + '-model' |
There was a problem hiding this comment.
Also can you update the docstring to capture this behavior.
morgandu force-pushed the mor--remove-model-display-name-requirement-for-training-jobs branch 2 times, most recently from 6720044 to 9c7f1e9 Compare 
| Please open this PR into the main branch instead of dev. |
morgandu force-pushed the mor--remove-model-display-name-requirement-for-training-jobs branch from 9c7f1e9 to 6cf7b83 Compare 
…en model_serving_container_image_uri is provided
morgandu force-pushed the mor--remove-model-display-name-requirement-for-training-jobs branch from 6cf7b83 to 72caf45 Compare morgandu deleted the mor--remove-model-display-name-requirement-for-training-jobs branch ivanmkc pushed a commit to ivanmkc/python-aiplatform that referenced this pull request Apr 21, 2021
…en model_serving_container_image_uri is provided (googleapis#324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #<b/184155454> 🦕