fix: project/location parsing for nested resources #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s 
sasha-gitg requested changes Sep 28, 2022
product-auto-label bot added size: m 
dizcology requested changes Sep 30, 2022
sasha-gitg requested changes Sep 30, 2022
dizcology approved these changes Sep 30, 2022
sasha-gitg approved these changes Sep 30, 2022
nayaknishant added automerge 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
For nested resources like EntityType (Featurestore -> EntityType -> Feature), the project/location needs to be extracted from the full resource name and passed into the client constructor. Adding check to see if parent exists and utility method to extract project and location from the parent resource name.
Fixes b/249363374 and #1684 🦕