- Notifications
You must be signed in to change notification settings - Fork 417
feat: Adds the temporal fusion transformer (TFT) forecasting job #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds the temporal fusion transformer (TFT) forecasting job #1654
Conversation
| 🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
e7cdd79 to b19d2c4 Compare | @sasha-gitg Hi there, I need a little help and I see you've done a lot of work in this repo. Do you often have this presubmit issue with pytest like, I don't think my PR has done anything particularly wild... I'm not sure how to fix this. Any ideas? If you think someone else might be better to ask, feel free to let me know |
| @mikelawrence-google Looks like an issue with python-xdist and Try changing back to list or following the sorted recommendation in the issue. |
| Thanks for taking a look, @sasha-gitg and @sararob. I thought it was more related to build infrastructure, but it was indeed the set vs list issue. My team is waiting on some documentation before we can merge, but will get the review going |
geraint0923 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the SDK support for TFT!
| training_jobs.SequenceToSequencePlusForecastingTrainingJob, | ||
| marks=pytest.mark.skip(reason="Seq2Seq not yet released."), | ||
| training_jobs.TemporalFusionTransformerForecastingTrainingJob, | ||
| marks=pytest.mark.skip(reason="TFT not yet released."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When will TFT be released? We should hold merging until it is released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend is ready, we are just waiting for documentation and some UI pieces. It's completely usable though. My TL suggested we merge it ahead of time with the understanding that customers can use it, just without the GA guarantees at launch time (~1 month out). What do you think?
This method can be directly inherited from its parent class since all that changes is the model type and schemas.
| We are doing maintenance on our repo starting today and need to close all open PRs. When this is done next week, you'll be able to open a new PR. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/239609625 🦕