Skip to content

fix: log_metrics docstring error #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2022
Merged

fix: log_metrics docstring error #1588

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c0b40c8
Update experiment_run_resource.py
jaycee-li Aug 11, 2022
1f1f7fe
fix: log_metrics docstring
jaycee-li Aug 11, 2022
bb99e3d
Merge branch 'fix-log-metrics' of https://github.com/jaycee-li/python…
jaycee-li Aug 11, 2022
eab11f3
Merge branch 'main' into fix-log-metrics
SinaChavoshi Aug 11, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/aiplatform/metadata/experiment_run_resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,7 +939,7 @@ def log_params(self, params: Dict[str, Union[float, int, str]]):
Required. Parameter key/value pairs.

Raises:
ValueError: If key is not str or value is not float, int, str.
TypeError: If key is not str or value is not float, int, str.
"""
# query the latest run execution resource before logging.
for key, value in params.items():
Expand Down Expand Up @@ -968,7 +968,7 @@ def log_metrics(self, metrics: Dict[str, Union[float, int, str]]):
```

Args:
metrics (Dict[str, Union[float, int]]):
metrics (Dict[str, Union[float, int, str]]):
Required. Metrics key/value pairs.
Raises:
TypeError: If keys are not str or values are not float, int, or str.
Expand Down