Skip to content

Feat: Add google.ClassificationMetrics, google.RegressionMetrics, and google.Forecasting Metrics #1549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 2, 2022
Merged

Feat: Add google.ClassificationMetrics, google.RegressionMetrics, and google.Forecasting Metrics #1549

merged 11 commits into from
Aug 2, 2022

Conversation

KevinBNaughton
Copy link
Contributor

@KevinBNaughton KevinBNaughton commented Jul 28, 2022 •
edited
Loading

Feat: Add google.ClassificationMetrics, google.RegressionMetrics, and google.Forecasting Metrics
@KevinBNaughton
Add google.ClassificationMetrics, google.RegressionMetrics, and googl…
27e5f55 
…e.ForecastingMetrics Artifact types to metadata schema with unit tests.
@KevinBNaughton KevinBNaughton requested a review from a team as a code owner July 28, 2022 18:43
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jul 28, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 28, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/
@product-auto-label product-auto-label bot added the api: vertex-ai Issues related to the googleapis/python-aiplatform API. label Jul 28, 2022
SinaChavoshi
SinaChavoshi requested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! looks great I only had a minor comment.
@077066456
Copy link

PUBG MAILE
SinaChavoshi
SinaChavoshi approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@SinaChavoshi SinaChavoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you for the PR!
@SinaChavoshi
Copy link
Contributor

I believe the error is a lint issue, two files need to be reformatted. You can run nox -s blacken from root of the repo to auto format the files. You can also run nox -s lint to validate no additional lint issues remaining ( some are not fixed by blacken).
jaycee-li
jaycee-li requested changes Aug 1, 2022
View reviewed changes
@jaycee-li jaycee-li merged commit 3526b3e into googleapis:main Aug 2, 2022
@release-please release-please bot mentioned this pull request Aug 2, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: l Pull request size is large.

4 participants

@KevinBNaughton @077066456 @SinaChavoshi @jaycee-li