Skip to content

feat: allow creating featurestore without online node #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2022
Merged

feat: allow creating featurestore without online node #1180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/aiplatform/featurestore/featurestore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ def create(
The value must be unique within the project and location.
online_store_fixed_node_count (int):
Optional. Config for online serving resources.
When not specified, default node count is 1. The
When not specified, no fixed node count for online serving. The
number of nodes will not scale automatically but
can be scaled manually by providing different
values when updating.
Expand Down Expand Up @@ -496,7 +496,7 @@ def create(
"""
gapic_featurestore = gca_featurestore.Featurestore(
online_serving_config=gca_featurestore.Featurestore.OnlineServingConfig(
fixed_node_count=online_store_fixed_node_count or 1
fixed_node_count=online_store_fixed_node_count
)
)

Expand Down
4 changes: 3 additions & 1 deletion tests/system/aiplatform/test_featurestore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ def test_create_get_list_featurestore(self, shared_state):
featurestore_id = self._make_display_name(key=_TEST_FEATURESTORE_ID).replace(
"-", "_"
)[:60]
featurestore = aiplatform.Featurestore.create(featurestore_id=featurestore_id)
featurestore = aiplatform.Featurestore.create(
featurestore_id=featurestore_id, online_store_fixed_node_count=1
)

shared_state["resources"] = [featurestore]
shared_state["featurestore"] = featurestore
Expand Down