fix: enforce bq SchemaField field_type and mode using feature value_type #1019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
morgandu force-pushed the mor--fix-feature-store-df-bq-schema branch from 4c49705 to 9c95e64 Compare …ngestion validation
ivanmkc reviewed Feb 23, 2022
| parquet_options=parquet_options, | ||
| ) | ||
| | ||
| job = bigquery_client.load_table_from_dataframe( |
There was a problem hiding this comment.
It looks like there's no assertion that the correct args are passed to bq_load_table_from_dataframe_mock. Perhaps add to a bq_load_table_from_dataframe_mock.assert_called_once_with(...) to test_ingest_from_df_using_column and test_ingest_from_df_using_datetime.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes b/220049963