Skip to content

chore: test cleanup #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
averikitsch merged 6 commits into from
Jan 13, 2025
Merged

chore: test cleanup #43

averikitsch merged 6 commits into from
Jan 13, 2025

Conversation

@vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Jan 13, 2025 •
edited
Loading

Following up on PR suggestion from: #32

Reviewer points:

  1. await engine._connector.close_async() seems not required at all instances of await engine.close().
    Example: when added to test_from_connection_string ref there's a failure suggesting:
    'NoneType' object has no attribute 'close_async'
@product-auto-label product-auto-label bot added the api: cloudsql-postgres Issues related to the googleapis/llama-index-cloud-sql-pg-python API. label Jan 13, 2025
@vishwarajanand vishwarajanand changed the title Test cleanup chore: test cleanup Jan 13, 2025
@vishwarajanand vishwarajanand marked this pull request as ready for review January 13, 2025 16:24
@vishwarajanand vishwarajanand requested review from a team as code owners January 13, 2025 16:24
@vishwarajanand vishwarajanand mentioned this pull request Jan 13, 2025
Merged
@averikitsch averikitsch merged commit bcd4100 into main Jan 13, 2025
8 checks passed
@averikitsch averikitsch deleted the test-cleanup branch January 13, 2025 23:26
@vishwarajanand vishwarajanand mentioned this pull request Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudsql-postgres Issues related to the googleapis/llama-index-cloud-sql-pg-python API.

2 participants

@vishwarajanand @averikitsch