refactor: Use named arguments instead of positional #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixed a bug where using both k and pre_filter search_kwargs caused in valid SQL generation.
product-auto-label bot added the api: spanner 
| /gcbrun |
averikitsch reviewed Oct 2, 2024
| /gcbrun |
| @aperepel, Can you please rebase the branch and fix the lint issues ? |
gauravpurohit06 changed the title | Updating the title to fix the |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixed a bug where using both k and pre_filter search_kwargs caused in valid SQL generation.
The broken SQL had
LIMIT <whatever_field>generated instead of using k. Moving away from position args fixed things.