Skip to content

deps: bump shared-deps version and add back certain test deps #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frankyn merged 2 commits into from
Jun 15, 2020
Merged

deps: bump shared-deps version and add back certain test deps #340

frankyn merged 2 commits into from
Jun 15, 2020

Conversation

@stephaniewang526
Copy link
Contributor

@stephaniewang526 stephaniewang526 commented May 27, 2020

No description provided.

@stephaniewang526 stephaniewang526 requested a review from frankyn May 27, 2020 17:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2020
@stephaniewang526 stephaniewang526 mentioned this pull request May 27, 2020
Closed
1 task
@codecov
Copy link

codecov bot commented May 27, 2020 •
edited
Loading

Codecov Report

Merging #340 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #340 +/- ## ============================================ + Coverage 62.71% 62.73% +0.01%  + Complexity 563 554 -9  ============================================ Files 31 31 Lines 5023 5023 Branches 479 480 +1 ============================================ + Hits 3150 3151 +1  + Misses 1708 1707 -1  Partials 165 165
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/storage/StorageImpl.java 80.52% <0.00%> (+0.12%) 131.00% <0.00%> (-9.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91fc36a...7367f45. Read the comment docs.
chingor13
chingor13 reviewed May 27, 2020
View reviewed changes
@stephaniewang526 stephaniewang526 mentioned this pull request May 28, 2020
Closed
1 task
@frankyn frankyn added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jun 15, 2020
@frankyn frankyn mentioned this pull request Jun 15, 2020
Closed
@frankyn
Copy link
Contributor

frankyn commented Jun 15, 2020

Thanks @stephaniewang526!
@frankyn frankyn added the automerge Merge the pull request once unit tests and other checks pass. label Jun 15, 2020
@frankyn frankyn mentioned this pull request Jun 15, 2020
Closed
1 task
@frankyn frankyn merged commit afd0339 into googleapis:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

4 participants

@stephaniewang526 @frankyn @chingor13 @googlebot