Skip to content

Conversation

@tronto20
Copy link
Contributor

@tronto20 tronto20 commented Sep 9, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1464 ☕️

If you write sample code, please follow the samples format.

goal

  • Default constructor of CloudStorageFileSystemProvider references only CloudStorageConfiguration
@tronto20 tronto20 requested review from a team as code owners September 9, 2024 00:57
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage-nio API. labels Sep 9, 2024
@tronto20 tronto20 force-pushed the minimize-initialize-at-buildtime branch from 0f9f1be to fb97392 Compare September 13, 2024 11:24
@mpeddada1 mpeddada1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 24, 2024
@mpeddada1 mpeddada1 closed this Nov 21, 2024
@mpeddada1 mpeddada1 reopened this Nov 21, 2024
@mpeddada1
Copy link
Contributor

Closing and re-opening PR to force run GA builds.

@sydney-munro sydney-munro merged commit fbc842d into googleapis:main Dec 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage-nio API. size: m Pull request size is medium.

4 participants