feat: adds samples for PITR #837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Adds sample for creating a database with a version retention period. Updates sample for creating a backup with a version time. Updates sample for restoring a backup, printing the backup version time.
| Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label bot added the api: spanner 
google-cla bot added the cla: yes product-auto-label bot added the samples 
thiagotnunes added the do not merge 
Contributor Author
| This should only be merged after we release a client library version with the PITR feature. (Before that we need to rebase over master). |
Codecov Report
@@ Coverage Diff @@ ## master #837 +/- ## ========================================= Coverage 85.22% 85.22% - Complexity 2650 2652 +2 ========================================= Files 145 145 Lines 14358 14358 Branches 1391 1391 ========================================= + Hits 12236 12237 +1 Misses 1539 1539 + Partials 583 582 -1
Continue to review full report at Codecov.
|
olavloite reviewed Feb 1, 2021
...ippets/src/main/java/com/example/spanner/CreateDatabaseWithVersionRetentionPeriodSample.java Show resolved Hide resolved
mmmarklu reviewed Feb 1, 2021
...ippets/src/main/java/com/example/spanner/CreateDatabaseWithVersionRetentionPeriodSample.java Show resolved Hide resolved
olavloite approved these changes Feb 3, 2021
olavloite reviewed Feb 22, 2021
samples/snippets/src/main/java/com/example/spanner/SpannerSample.java Outdated Show resolved Hide resolved
Uses the earliest version time from the database as the version time for the backup.
olavloite approved these changes Feb 23, 2021
Contributor Author
| We need to wait for the snippets BOM to be updated to the version that contains the PITR changes (>= 4.0.0) before we can merge this PR. |
thiagotnunes removed the do not merge * samples: creates a backup using the current time Instead of using the earliest version time of the database, uses the current time (from spanner). If we used the earliest version time of the database instead we would be creating an empty backup, since the database we are backing up is not 1 hour old (default version retention period). * samples: remove unused variable Clean up create backup samples by removing unused variable.
Contributor Author
| Do not delete the this branch, it is still referred by the docs. |
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
* chore(ci): replace accidentally removed install steps * force go version 1.18.3 * fix apidiff target * try upload/download of baseline * upload package diff file * remove diff upload * add retention-days
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds sample for creating a database with a version retention period. Updates sample for creating a backup with a version time. Updates sample for restoring a backup, printing the backup version time.