test: increase timeout to prevent flakiness #709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
google-cla bot added the cla: yes 
product-auto-label bot added the api: spanner 
olavloite added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
thiagotnunes approved these changes Dec 10, 2020
Codecov Report
@@ Coverage Diff @@ ## master #709 +/- ## ============================================ + Coverage 85.05% 85.10% +0.05% - Complexity 2556 2560 +4 ============================================ Files 142 142 Lines 13930 13930 Branches 1326 1326 ============================================ + Hits 11848 11855 +7 + Misses 1526 1519 -7 Partials 556 556
Continue to review full report at Codecov.
|
thiagotnunes pushed a commit that referenced this pull request May 6, 2021
ansh0l pushed a commit to ansh0l/java-spanner that referenced this pull request Nov 10, 2022
This is an auto-generated regeneration of the .pb.go files by cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will update the corresponding PR to depend on the newer version of go-genproto, and assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot will not create any more regeneration PRs. If all regen PRs are closed, gapicgen will create a new set of regeneration PRs once per night. If you have been assigned to review this PR, please: - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. That will prompt genbot to assign reviewers to the google-cloud-go PR. Corresponding google-cloud-go PR: googleapis/google-cloud-go#5035 Changes: chore: regenerate API index Source-Link: googleapis/googleapis@c33c435 feat: Cloud IDS client v1 Based on: https://cloud.google.com/ids/docs PiperOrigin-RevId: 405832509 Source-Link: googleapis/googleapis@a61dbc0 chore(security/privateca): Update privateca BUILD.bazel package name to google-cloud-private-ca PiperOrigin-RevId: 405697254 Source-Link: googleapis/googleapis@4ee0e57 docs(security/privateca): fix docstring formatting Committer: @parthea PiperOrigin-RevId: 405687537 Source-Link: googleapis/googleapis@5f897f0 feat: Publish Cloud Integrations logging proto for documentation Committer: @jinmichaelgu PiperOrigin-RevId: 405667694 Source-Link: googleapis/googleapis@7f52277
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
…v6.17.4 (googleapis#709) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner-bom](https://togithub.com/googleapis/java-spanner) | `6.17.3` -> `6.17.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-spanner</summary> ### [`v6.17.4`](https://togithub.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#​6174-httpswwwgithubcomgoogleapisjava-spannercomparev6173v6174-2022-01-07) [Compare Source](https://togithub.com/googleapis/java-spanner/compare/v6.17.3...v6.17.4) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-spanner-jdbc).
rajatbhatta pushed a commit to rajatbhatta/java-spanner that referenced this pull request Nov 17, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.8](https://www.github.com/googleapis/java-spanner-jdbc/compare/v2.5.7...v2.5.8) (2022-01-07) ### Dependencies * update dependency com.google.cloud:google-cloud-spanner-bom to v6.17.4 ([googleapis#709](https://www.github.com/googleapis/java-spanner-jdbc/issues/709)) ([bd12d7c](https://www.github.com/googleapis/java-spanner-jdbc/commit/bd12d7c33b18ceb1df417df8e275ffa745b195b2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
StatementTimeoutTest.testTimeoutExceptionReadWriteTransactionMultipleStatementshad become flaky because of a combination of two other changes:BeginTransactionoption. If that statement fails with an error, the entire transaction will be retried, but then with an explicitBeginTransactionRPC. The latter is done to ensure that the statement that returned an error will be included in the transaction.Aborted, and then during a retry would returnAborted.The combination of the two above changes means that the first statement of a transaction can take longer than expected when it returns an error, as it will automatically trigger a retry of the transaction, and thereby also be executed twice without the client application knowing.
Fixes #708