chore(deps): update dependency com.google.cloud:google-cloud-spanner-parent to v6.106.0-rc1 #4274
Conversation
…parent to v6.106.0-rc1
product-auto-label bot added size: s 
| /gcbrun |
trusted-contributions-gcf bot added the kokoro:force-run 
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the update of the Google Cloud Spanner parent dependency to its latest release candidate version. The primary goal is to ensure the project benefits from the most recent features, bug fixes, and internal dependency alignments within the Google Cloud Spanner client library ecosystem, including an important update to Protobuf code generation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the parent POM version in several submodules to 6.106.0-rc1, but the update is incomplete and will break the build. The root pom.xml, which defines the google-cloud-spanner-parent artifact, is not updated from version 6.105.1-SNAPSHOT. This version mismatch will cause the Maven multi-module build to fail. Additionally, individual module versions have not been updated, leading to further inconsistencies. For the build to succeed and to ensure a consistent release, all versions across the project (in the root POM, submodule POMs, and BOMs) should be updated to 6.106.0-rc1 in a single, atomic change. Finally, please be aware that this updates to a release candidate version (-rc1), which may not be suitable for a production release.
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-spanner-parent</artifactId> | ||
| <version>6.105.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-spanner:current} --> | ||
| <version>6.106.0-rc1</version><!-- {x-version-update:google-cloud-spanner:current} --> |
There was a problem hiding this comment.
Updating the parent version here to 6.106.0-rc1 without also updating the version in the root pom.xml will break the Maven reactor build. The root pom.xml still defines the parent artifact with version 6.105.1-SNAPSHOT. All module versions should be updated consistently, starting from the root.
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-cloud-spanner-parent</artifactId> | ||
| <version>6.105.1-SNAPSHOT</version><!-- {x-version-update:google-cloud-spanner:current} --> | ||
| <version>6.106.0-rc1</version><!-- {x-version-update:google-cloud-spanner:current} --> |
There was a problem hiding this comment.
While the parent version is updated here, this module's own version (defined on line 8) remains 6.105.1-SNAPSHOT. This creates an inconsistency between the module and its parent. For a proper release, all module versions in the project should be updated along with the parent version.
yoshi-kokoro removed kokoro:force-run 3 participants
This PR contains the following updates:
6.105.1-SNAPSHOT->6.106.0-rc1Release Notes
googleapis/java-spanner (com.google.cloud:google-cloud-spanner-parent)
v6.106.0-rc1Compare Source
Features
10c6c11)Dependencies
c349767)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.