fix: always add instance-id for built-in metrics #3612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The instance-id was only added for built-in metrics when the headers of the request was sent. This meant that any request that would NOT get sent would not include an instance-id, which again would cause the export of ALL built-in metrics to stop. This would happen because the metric without an instance-id would remain in the collected metrics. A request would get into this state if the client ran into a network issue that would prevent the client from making a network connection to Spanner. Fixes #3611
product-auto-label bot added size: m 
surbhigarg92 approved these changes Jan 27, 2025
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Feb 3, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.85.0` -> `6.86.0` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.86.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6860-2025-01-31) ##### Features - Add sample for asymmetric autoscaling instances ([#​3562](googleapis/java-spanner#3562)) ([3584b81](googleapis/java-spanner@3584b81)) - Support graph and pipe queries in Connection API ([#​3586](googleapis/java-spanner#3586)) ([71c3063](googleapis/java-spanner@71c3063)) ##### Bug Fixes - Always add instance-id for built-in metrics ([#​3612](googleapis/java-spanner#3612)) ([705b627](googleapis/java-spanner@705b627)) - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.1 ([3e27251](googleapis/java-spanner@3e27251)) - **deps:** Update the Java code generator (gapic-generator-java) to 2.52.0 ([bf69673](googleapis/java-spanner@bf69673)) - **spanner:** Moved mTLSContext configurator from builder to construtor ([#​3605](googleapis/java-spanner#3605)) ([ac7c30b](googleapis/java-spanner@ac7c30b)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#​3616](googleapis/java-spanner#3616)) ([2ea59f0](googleapis/java-spanner@2ea59f0)) - Update dependency io.opentelemetry:opentelemetry-bom to v1.46.0 ([#​3530](googleapis/java-spanner#3530)) ([d505850](googleapis/java-spanner@d505850)) ##### Documentation - Clarify how async updates can overtake each other ([#​3581](googleapis/java-spanner#3581)) ([1be250f](googleapis/java-spanner@1be250f)) - Fix typo timzeone -> timezone ([bf69673](googleapis/java-spanner@bf69673)) - Fixed parameter arguments for AbstractResultSet's Listener's on TransactionMetadata doc ([#​3602](googleapis/java-spanner#3602)) ([1f143a4](googleapis/java-spanner@1f143a4)) - **samples:** Add samples and tests for change streams transaction exclusion ([#​3098](googleapis/java-spanner#3098)) ([1f81600](googleapis/java-spanner@1f81600)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: ae3d6e05ea6da84db9faf0e473fd148d6ad36a6e
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The instance-id was only added for built-in metrics when the headers of the request was sent. This meant that any request that would NOT get sent would not include an instance-id, which again would cause the export of ALL built-in metrics to stop. This would happen because the metric without an instance-id would remain in the collected metrics.
A request would get into this state if the client ran into a network issue that would prevent the client from making a network connection to Spanner.
Fixes #3611