Skip to content

Conversation

rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Jan 9, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/388699606 ☕️

If you write sample code, please follow the samples format.

@rahul2393 rahul2393 requested a review from a team as a code owner January 9, 2025 07:46
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jan 9, 2025
@rahul2393 rahul2393 changed the title feat: add LockHint feature #10382 feat: add LockHint feature Jan 9, 2025
@rahul2393 rahul2393 force-pushed the support-read-lockhint branch from 659d8b8 to 02fd8fb Compare January 9, 2025 07:47
@rahul2393
Copy link
Contributor Author

rahul2393 commented Jan 9, 2025

@mayurkale22 any specific reason PR was not raised in Java, I see you raised for Go
googleapis/google-cloud-go#10382

@rahul2393 rahul2393 merged commit 326442b into main Jan 9, 2025
34 checks passed
@rahul2393 rahul2393 deleted the support-read-lockhint branch January 9, 2025 13:38
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jan 13, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.84.0` -> `6.85.0` | | [com.google.apis:google-api-services-cloudkms](http://nexus.sonatype.org/oss-repository-hosting.html) ([source](http://svn.sonatype.org/spice/tags/oss-parent-7)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `v1-rev20241111-2.0.0` -> `v1-rev20250102-2.0.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.25.1` -> `2.25.2` | | [com.autonomousapps.dependency-analysis](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin) | plugin | misk/gradle/libs.versions.toml | gradle | minor | `2.6.1` -> `2.7.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.49` -> `2.29.50` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.49` -> `2.29.50` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.49` -> `2.29.50` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.49` -> `2.29.50` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.49` -> `2.29.50` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.49` -> `2.29.50` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.85.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6850-2025-01-10) ##### Features - Add gcp client attributes in OpenTelemetry traces ([#&#8203;3595](googleapis/java-spanner#3595)) ([7893f24](googleapis/java-spanner@7893f24)) - Add LockHint feature ([#&#8203;3588](googleapis/java-spanner#3588)) ([326442b](googleapis/java-spanner@326442b)) - **spanner:** MTLS setup for spanner external host clients ([#&#8203;3574](googleapis/java-spanner#3574)) ([f8dd152](googleapis/java-spanner@f8dd152)) ##### Dependencies - Update dependency com.google.api.grpc:proto-google-cloud-monitoring-v3 to v3.56.0 ([#&#8203;3563](googleapis/java-spanner#3563)) ([e4d0b0f](googleapis/java-spanner@e4d0b0f)) - Update dependency com.google.api.grpc:proto-google-cloud-monitoring-v3 to v3.57.0 ([#&#8203;3592](googleapis/java-spanner#3592)) ([a7542da](googleapis/java-spanner@a7542da)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.41.1 ([#&#8203;3589](googleapis/java-spanner#3589)) ([2cd4238](googleapis/java-spanner@2cd4238)) - Update dependency com.google.cloud.opentelemetry:exporter-trace to v0.33.0 ([#&#8203;3455](googleapis/java-spanner#3455)) ([70649dc](googleapis/java-spanner@70649dc)) - Update dependency com.google.re2j:re2j to v1.8 ([#&#8203;3594](googleapis/java-spanner#3594)) ([0f2013d](googleapis/java-spanner@0f2013d)) - Update googleapis/sdk-platform-java action to v2.51.1 ([#&#8203;3591](googleapis/java-spanner#3591)) ([3daa1a0](googleapis/java-spanner@3daa1a0)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.25.2`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2252-2025-01-09) ##### Bug Fixes - **deps:** Update the Java code generator (gapic-generator-java) to 2.51.1 ([90d8b30](googleapis/java-datastore@90d8b30)) - Fix emulator command arg data-dir ([#&#8203;1695](googleapis/java-datastore#1695)) ([9d53195](googleapis/java-datastore@9d53195)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.49.0 ([#&#8203;1693](googleapis/java-datastore#1693)) ([8160c28](googleapis/java-datastore@8160c28)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.41.1 ([#&#8203;1703](googleapis/java-datastore#1703)) ([bf9537f](googleapis/java-datastore@bf9537f)) - Update dependency com.google.guava:guava-testlib to v33.4.0-jre ([#&#8203;1694](googleapis/java-datastore#1694)) ([b91a2af](googleapis/java-datastore@b91a2af)) </details> <details> <summary>autonomousapps/dependency-analysis-android-gradle-plugin (com.autonomousapps.dependency-analysis)</summary> ### [`v2.7.0`](https://github.com/autonomousapps/dependency-analysis-android-gradle-plugin/blob/HEAD/CHANGELOG.md#Version-270) - \[Feat]: can set severity and filter duplicate class warnings. - \[Feat]: don't recommend removing implementation dependency on necessary superclass. - \[Chore]: use non-deprecated method when available. - \[Chore]: update various dependencies, including antlr. New DSL option for configuring duplicate class warnings: ```groovy // root build.gradle[.kts] dependencyAnalysis { issues { all { onDuplicateClassWarnings { severity(<"fail"|"warn"|"ignore">) // Fully-qualified class reference to exclude, slash- or dot-delimited exclude("org/jetbrains/annotations/NotNull", "org.jetbrains.annotations.Nullable") } } } } ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: c370d05a3d2bb5c849f728746c58480ba5faf607
@suztomo suztomo mentioned this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

2 participants