chore: add support for OpenTelemetry metrics to Connection API #2896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
olavloite reviewed Feb 19, 2024
google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionOptions.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/SpannerPool.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/SpannerPool.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionOptions.java Show resolved Hide resolved
hengfengli force-pushed the support-otel-in-conn-api branch 2 times, most recently from 518a1f4 to fa2c795 Compare product-auto-label bot added size: s hengfengli force-pushed the support-otel-in-conn-api branch from fa2c795 to 754b75b Compare product-auto-label bot added size: m hengfengli force-pushed the support-otel-in-conn-api branch from 754b75b to 7d76782 Compare olavloite approved these changes Feb 26, 2024
Collaborator
olavloite left a comment
olavloite left a comment There was a problem hiding this comment.
LGTM, except for the comment on what to do when no OpenTelemetry has been set. I think that we should just return null, and let SpannerOptions determine the default.
google-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/ConnectionOptions.java Outdated Show resolved Hide resolved
hengfengli force-pushed the support-otel-in-conn-api branch from 351c976 to a95c22d Compare 
olavloite added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds support for OpenTelemetry metrics in the Connection API.