Skip to content

feat: add PartitionedUpdate support to executor #2228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 9 commits into from
Mar 15, 2023
Merged

feat: add PartitionedUpdate support to executor #2228

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
661df5f
feat: add PartitionedUpdate support to executor
rajatbhatta Jan 12, 2023
90539fc
add fromProto to RpcPriority enum
rajatbhatta Jan 12, 2023
9737322
Merge branch 'googleapis:main' into partitioned-dml-executor
rajatbhatta Feb 25, 2023
355f794
lint fixes
rajatbhatta Mar 1, 2023
ddacf16
Merge branch 'googleapis:main' into partitioned-dml-executor
rajatbhatta Mar 6, 2023
65c152f
address review comments
rajatbhatta Mar 6, 2023
ab9c94a
address review comments
rajatbhatta Mar 6, 2023
bac3a44
linting fix
rajatbhatta Mar 15, 2023
ffd1dc3
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Mar 15, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint fixes
  • Loading branch information
@rajatbhatta
rajatbhatta committed Mar 1, 2023
commit 355f794d80f768ec2d3f39dc133dbfb82b00a12c
6 changes: 3 additions & 3 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/Options.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@ public enum RpcPriority {
this.proto = Preconditions.checkNotNull(proto);
}

public static RpcPriority fromProto(Priority proto){
for(RpcPriority e : RpcPriority.values()){
if(e.proto.equals(proto)) return e;
public static RpcPriority fromProto(Priority proto) {
for (RpcPriority e : RpcPriority.values()) {
if (e.proto.equals(proto)) return e;
}
return null;
Copy link
Contributor

@arpan14 arpan14 Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's preferred to not return nulls and instead return some modelled type like UNRECOGNIZED/UNKNOWN/UNSPECIFIED. With nulls, the client does not have a good way to know underlying reason i.e invalid enum type being the actual issue.
Copy link
Contributor Author

@rajatbhatta rajatbhatta Mar 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a RpcPriority.UNSPECIFIED to enum to map to Priority.PRIORITY_UNSPECIFIED. If a null value is passed in, we would return RpcPriority.UNSPECIFIED.
}
Expand Down