Skip to content

Conversation

mohanli-ml
Copy link
Contributor

Register gRPC RLS for DirectPath.

@mohanli-ml mohanli-ml requested review from a team as code owners May 12, 2022 19:29
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels May 12, 2022
@ansh0l ansh0l added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2022
@ansh0l ansh0l requested a review from rajatbhatta May 13, 2022 05:32
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @mohanli-ml : Please coordinate with @rajatbhatta for running nightly tests. I am adding a Do not merge label pending that.

@ansh0l ansh0l added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 13, 2022
@ansh0l ansh0l added the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2022
@ansh0l ansh0l added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 23, 2022
@ansh0l ansh0l removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 19, 2022
@ansh0l ansh0l added the priority: p0 Highest priority. Critical issue. P0 implies highest priority. label Sep 6, 2022
This is to remove warnings while building.
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add these dependencies to ignoredDependencies list, to fix the unused dependencies warning during ci / dependencies Github check. LGTM now.

@rajatbhatta rajatbhatta added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 31cf06e into googleapis:main Sep 8, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 8, 2022
gcf-owl-bot bot added a commit that referenced this pull request Oct 3, 2023
…es/java_library/.kokoro (#1875) chore: bump urllib3 in /synthtool/gcp/templates/java_library/.kokoro Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.17. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.16...1.26.17) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Source-Link: googleapis/synthtool@dbb940f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6e2fc7eba84c3100cde964ebcfd0e553d4664ec4a74989c978a143812785ff23
arpan14 pushed a commit that referenced this pull request Oct 11, 2023
…es/java_library/.kokoro (#1875) (#2652) chore: bump urllib3 in /synthtool/gcp/templates/java_library/.kokoro Bumps [urllib3](https://github.com/urllib3/urllib3) from 1.26.16 to 1.26.17. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@1.26.16...1.26.17) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Source-Link: googleapis/synthtool@dbb940f Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:6e2fc7eba84c3100cde964ebcfd0e553d4664ec4a74989c978a143812785ff23 Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. size: s Pull request size is small.
4 participants