Skip to content

feat: Updating readme with new gfe latency metrics #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2022
Merged

feat: Updating readme with new gfe latency metrics #1630

merged 2 commits into from
Jan 11, 2022

Conversation

KiranmayiB
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️
@KiranmayiB KiranmayiB requested review from a team as code owners January 6, 2022 08:31
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Jan 6, 2022
ansh0l
ansh0l approved these changes Jan 6, 2022
View reviewed changes
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. But I see that #1629 is closed, would there be any changes further needed for samples after this one?
@KiranmayiB
Copy link
Contributor Author

lgtm. But I see that #1629 is closed, would there be any changes further needed for samples after this one?

I closed #1629 as it was created accidentally. There wont be any changes after this.
@thiagotnunes
Copy link
Contributor

@KiranmayiB do you want to update the opencensus version in the README as well? (https://github.com/googleapis/java-spanner/blob/main/.readme-partials.yaml#L86-L104)

Do you want to update the way we register the opencensus stackdriver collector configuration? (https://github.com/googleapis/java-spanner/blob/main/.readme-partials.yaml#L106-L116)
@thiagotnunes thiagotnunes added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2022
@thiagotnunes thiagotnunes added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 10, 2022
@ansh0l ansh0l merged commit d02601a into googleapis:main Jan 11, 2022
@release-please release-please bot mentioned this pull request Jan 11, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 4, 2022
@release-please
chore(main): release 6.18.0 (#1641)
9dec77b 
🤖 I have created a release *beep* *boop* --- ## [6.18.0](v6.17.4...v6.18.0) (2022-02-03) ### Features * add database dialect ([#1657](#1657)) ([269f090](269f090)) * Updating readme with new gfe latency metrics ([#1630](#1630)) ([d02601a](d02601a)) ### Dependencies * **java:** update actions/github-script action to v5 ([#1339](#1339)) ([#1659](#1659)) ([203b346](203b346)) * update actions/github-script action to v5 ([#1658](#1658)) ([a2f3790](a2f3790)) * update dependency com.google.cloud:google-cloud-monitoring to v3.2.1 ([#1637](#1637)) ([73c9434](73c9434)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.7.0 ([#1662](#1662)) ([ece31c0](ece31c0)) * update opencensus.version to v0.31.0 ([#1661](#1661)) ([1e86a3a](1e86a3a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API.
3 participants
@KiranmayiB @thiagotnunes @ansh0l