Skip to content

Conversation

olavloite
Copy link
Collaborator

@olavloite olavloite commented Apr 28, 2022

Bumps Spanner to 6.23.3 and modifies SQL script test files to reflect the changes for client side statements for PG.

Replaces #788

@olavloite olavloite requested review from a team as code owners April 28, 2022 15:18
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: spanner Issues related to the googleapis/java-spanner-jdbc API. labels Apr 28, 2022
@olavloite olavloite requested review from ansh0l and rajatbhatta April 29, 2022 06:47
Copy link
Contributor

@ansh0l ansh0l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansh0l
Copy link
Contributor

ansh0l commented May 14, 2022

@mpeddada1 There seems to be some NPE leading to presubmit failures because the config is not correctly being picked. Example java.lang.NullPointerException: Property spanner.testenv.config.class needs to be set. Please check.

@blakeli0 blakeli0 added the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit b7b8efa into main May 24, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the spanner-6.23.3 branch May 24, 2022 01:18
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request May 24, 2022
🤖 I have created a release *beep* *boop* --- ## [2.7.0](v2.6.4...v2.7.0) (2022-05-24) ### Features * add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#875](#875)) ([600e401](600e401)) ### Dependencies * bump Spanner to 6.23.3 ([#862](#862)) ([b7b8efa](b7b8efa)), closes [#788](#788) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#874](#874)) ([d403f54](d403f54)) * update opencensus.version to v0.31.1 ([#865](#865)) ([61ba9be](61ba9be)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner-jdbc API. size: xl Pull request size is extra large.

3 participants