fix: allow dots and colons in project id #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The project ID part of a connection URL should allow the use of dots and colons. Fixes #33
googlebot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #36 +/- ## ========================================= Coverage 77.79% 77.79% Complexity 1713 1713 ========================================= Files 60 60 Lines 5854 5854 Branches 819 819 ========================================= Hits 4554 4554 Misses 926 926 Partials 374 374
Continue to review full report at Codecov.
|
hengfengli reviewed Jan 21, 2020
src/main/java/com/google/cloud/spanner/jdbc/ConnectionOptions.java Outdated Show resolved Hide resolved
hengfengli approved these changes Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The project ID part of a connection URL should allow the use of dots and colons. This PR also replaces all usages of the deprecated class
org.junit.Assertin the affected test classes withcom.google.common.truth.Truth.Fixes #33