- Notifications
You must be signed in to change notification settings - Fork 48
feat: Expose Datastore Admin generated client #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Warning: This pull request is touching the following templated files:
|
75816ce
to 384c707
Compare d71f4dc
to e5b016e
Compare 26638cc
to 14e7b8a
Compare kolea2 reviewed May 27, 2022
grpc-google-cloud-datastore-v1/src/main/java/com/google/datastore/v1/DatastoreGrpc.java Outdated Show resolved Hide resolved
a81ab5a
to 32b1d7a
Compare Correct missing dependencies not generated by owl.
I think actually ready for review now @kolea2, thanks for your help! |
kolea2 reviewed May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, one comment/question. Thanks!
kolea2 approved these changes May 31, 2022
This was referenced May 31, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request May 31, 2022
🤖 I have created a release *beep* *boop* --- ## [2.6.0](v2.5.1...v2.6.0) (2022-05-31) ### Features * Expose Datastore Admin generated client ([#748](#748)) ([3dd882a](3dd882a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Can we do the same for the regular Datastore client? There is no |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: xl Pull request size is extra large.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.