- Notifications
You must be signed in to change notification settings - Fork 48
fix(java): rename test to be picked up by native profile #723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits Select commit Hold shift + click to select a range
110ce01
fix(java): rename test to be picked up by native profile
mpeddada1 8208b11
remove surefire config; use Truth
mpeddada1 d195aae
uncomment tests
mpeddada1 97b3194
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 8cf2681
Merge branch 'rename-test' of https://github.com/googleapis/java-data…
gcf-owl-bot[bot] 7e248a9
restore changes
mpeddada1 3575af9
Merge branch 'rename-test' of github.com:googleapis/java-datastore in…
mpeddada1 3f68f1d
remove comment
mpeddada1 02bd3fe
use recent version of java-shared-config
mpeddada1 74df084
update version
mpeddada1 edb8206
Merge branch 'main' of github.com:googleapis/java-datastore into rena…
mpeddada1 a2dc041
downgrade shared config to check
mpeddada1 3a3ed30
temporarily comment out surefire
mpeddada1 9c9f94c
add config for tests
mpeddada1 9fb97ec
use maven-failsafe
mpeddada1 e309f2b
remove comment
mpeddada1 78084dc
fix maven configuration
mpeddada1 89c2f64
exclude smoke test
mpeddada1 512b9af
use maven surefire
mpeddada1 40a5c04
rely on java-shared-config versions
mpeddada1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions 1 datastore-v1-proto-client/src/main/resources/META-INF/native-image/native-image.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Args = --enable-url-protocols=https,http | ||
32 changes: 32 additions & 0 deletions 32 datastore-v1-proto-client/src/main/resources/META-INF/native-image/reflect-config.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
[ | ||
{ | ||
"name":"com.google.datastore.v1.client.Datastore", | ||
"methods":[ | ||
{"name":"allocateIds","parameterTypes":["com.google.datastore.v1.AllocateIdsRequest"] }, | ||
{"name":"beginTransaction","parameterTypes":["com.google.datastore.v1.BeginTransactionRequest"] }, | ||
{"name":"commit","parameterTypes":["com.google.datastore.v1.CommitRequest"] }, | ||
{"name":"lookup","parameterTypes":["com.google.datastore.v1.LookupRequest"] }, | ||
{"name":"reserveIds","parameterTypes":["com.google.datastore.v1.ReserveIdsRequest"] }, | ||
{"name":"rollback","parameterTypes":["com.google.datastore.v1.RollbackRequest"] }, | ||
{"name":"runQuery","parameterTypes":["com.google.datastore.v1.RunQueryRequest"] } | ||
] | ||
}, | ||
{ | ||
"name":"com.google.api.client.http.HttpRequest", | ||
"allDeclaredFields":true, | ||
"allPublicFields":true, | ||
"allDeclaredMethods":true, | ||
"allPublicMethods":true, | ||
"allDeclaredConstructors" : true, | ||
"allPublicConstructors" : true | ||
}, | ||
{ | ||
"name":"com.google.api.client.http.HttpHeaders", | ||
"allDeclaredFields":true, | ||
"allPublicFields":true, | ||
"allDeclaredMethods":true, | ||
"allPublicMethods":true, | ||
"allDeclaredConstructors" : true, | ||
"allPublicConstructors" : true | ||
} | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this library use HTTP (not HTTPS) somewhere in users' environment? (What's the error without this argument?)
If the request is only for testing, then this file should be under test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the stacktrace, this is coming from
com.google.datastore.v1.client.RemoteRpc
:Normally this configuration would come from gax, but this module doesn't import it so we had to add this setting in.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe
RemoteRpc
constructor takes an HTTP URL. Where is the value defined? (My guess is it's only for tests)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error is coming from
RemoteRpc.resolveURL
but it's used inRemoteRpc#call
which is later referenced inDatastore
. For this reason, I think we would still need it in the main configuration?