samples: migrate samples from GoogleCloudPlatform/java-docs-samples /bigtable/snippets #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Bigtable Writes samples for Java Client * Adding increment comment * Correcting bytes written in previous tests
* WIP for Bigtable Read and Filter snippets * Remaining Filter snippets WIP * All tests working, improved interleave label and condition, removed sink * Changing time to java.time Adding comments about filtering Handling exceptions Reformatting Reads print output other cleanups * Updating function declarations * Cleanup requireEnv function.
* Read and filter snippets for Hbase Bigtable Reads done Filters WIP, issues with Pass and ColRange. Some nuances to sort out between HBase and other clients still * Filter snippets * Remove unused region tags Co-authored-by: Les Vogel <lesv@users.noreply.github.com>
* Update read region tags * Update region tags for filters * Move region tags in filters * Move region tags out of class * Update tags for java * change generic to print * update java bigtable filters region tags * make into one sample * untrack hbase-test * change function to code * lint everything
Fixes #issue > It's a good idea to open an issue first for discussion. - [ ] I have followed [Sample Format Guide](https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md) - [ ] `pom.xml` parent set to latest `shared-configuration` - [ ] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [x] **Tests** pass: `mvn clean verify` **required** - [x] **Lint** passes: `mvn -P lint checkstyle:check` **required** - [ ] **Static Analysis**: `mvn -P lint clean compile pmd:cpd-check spotbugs:check` **advisory only** - [x] Please **merge** this PR for me once it is approved.
google-cla bot added the cla: yes 
Contributor
Codecov Report
@@ Coverage Diff @@ ## master #376 +/- ## ========================================= Coverage 80.24% 80.24% Complexity 1102 1102 ========================================= Files 105 105 Lines 6815 6815 Branches 364 364 ========================================= Hits 5469 5469 Misses 1148 1148 Partials 198 198 Continue to review full report at Codecov.
|
billyjacobson approved these changes Aug 7, 2020
chingor13 commented Aug 7, 2020
BenWhitehead approved these changes Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.