Skip to content

Conversation

@kolea2
Copy link
Contributor

@kolea2 kolea2 commented May 28, 2020

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 28, 2020
@kolea2 kolea2 requested a review from igorbernstein2 May 28, 2020 14:57
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #324 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #324 +/- ## ============================================ - Coverage 80.72% 80.36% -0.36%  + Complexity 1050 1049 -1  ============================================ Files 99 99 Lines 6541 6541 Branches 344 343 -1 ============================================ - Hits 5280 5257 -23  + Misses 1081 1080 -1  - Partials 180 204 +24 
Impacted Files Coverage Δ Complexity Δ
...igtable/admin/v2/BaseBigtableTableAdminClient.java 58.18% <0.00%> (-4.73%) 67.00% <0.00%> (ø%)
...able/admin/v2/BaseBigtableInstanceAdminClient.java 57.07% <0.00%> (-4.40%) 56.00% <0.00%> (ø%)
...able/gaxx/reframing/ReframingResponseObserver.java 89.28% <0.00%> (-1.79%) 29.00% <0.00%> (-1.00%)
...om/google/cloud/bigtable/emulator/v2/Emulator.java 59.13% <0.00%> (+0.86%) 14.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf23ab6...deb3587. Read the comment docs.

Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kolea2 kolea2 merged commit 8f76fc8 into googleapis:master May 28, 2020
@kolea2 kolea2 deleted the shared-deps-update branch May 28, 2020 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants