Skip to content

fix: remove grpclb #2033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorbernstein2 merged 8 commits into from
Jun 25, 2024
Merged

fix: remove grpclb #2033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2606c92
fix: remove grpclb
mohanli-ml Dec 18, 2023
bb8af20
fix: remove grpclb
mohanli-ml Dec 18, 2023
dcb4df6
Merge branch 'master' into remove-grpclb
mohanli-ml Apr 18, 2024
46013f3
fix: remove grpclb
mohanli-ml Apr 18, 2024
80d3fd7
fix: remove grpclb
mohanli-ml Apr 19, 2024
5596947
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 11, 2024
0373b03
Merge branch 'main' into remove-grpclb
igorbernstein2 May 11, 2024
70ed201
Merge branch 'main' into remove-grpclb
igorbernstein2 Jun 24, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions google-cloud-bigtable/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,6 @@
<groupId>io.grpc</groupId>
<artifactId>grpc-core</artifactId>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-grpclb</artifactId>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-googleapis</artifactId>
Expand Down Expand Up @@ -698,11 +693,10 @@
<artifactId>maven-dependency-plugin</artifactId>
<configuration>
<!--
grpc-grpclb is used at runtime using reflection
grpc-auth is not directly used transitively, but is pulled to align with other grpc parts
opencensus-impl-core is brought in transitively through opencensus-impl
-->
<usedDependencies>io.grpc:grpc-auth,io.grpc:grpc-grpclb</usedDependencies>
<usedDependencies>io.grpc:grpc-auth</usedDependencies>
<ignoredUsedUndeclaredDependencies>
<ignoredUsedUndeclaredDependency>io.opencensus:opencensus-impl-core</ignoredUsedUndeclaredDependency>
</ignoredUsedUndeclaredDependencies>
Expand Down
5 changes: 1 addition & 4 deletions ...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStubSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,10 +356,7 @@ public static InstantiatingGrpcChannelProvider.Builder defaultGrpcTransportProvi
.setMaxInboundMessageSize(MAX_MESSAGE_SIZE)
.setKeepAliveTime(Duration.ofSeconds(30)) // sends ping in this interval
.setKeepAliveTimeout(
Duration.ofSeconds(10)) // wait this long before considering the connection dead
// Attempts direct access to CBT service over gRPC to improve throughput,
// whether the attempt is allowed is totally controlled by service owner.
.setAttemptDirectPath(true);
Duration.ofSeconds(10)); // wait this long before considering the connection dead
}

@SuppressWarnings("WeakerAccess")
Expand Down