Skip to content

deps: upgrade maven-enforcer-plugin to 3.3.0, remove duplicate entry in pom #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023
Merged

deps: upgrade maven-enforcer-plugin to 3.3.0, remove duplicate entry in pom #1702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 21 additions & 28 deletions google-cloud-bigtable/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,33 +607,6 @@
</extension>
</extensions>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>3.1.0</version>
<executions>
<execution>
<id>enforce-declared-grpc-and-proto-version</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<bannedDependencies>
<includes>
<dependency>io.grpc:*:[${grpc.version}]</dependency>
<dependency>com.google.protobuf:*:[${protobuf.version}]</dependency>
</includes>
<excludes>
<dependency>io.grpc:*</dependency>
<dependency>com.google.protobuf:*</dependency>
</excludes>
</bannedDependencies>
</rules>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.xolstice.maven.plugins</groupId>
<artifactId>protobuf-maven-plugin</artifactId>
Expand Down Expand Up @@ -678,7 +651,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>3.2.1</version>
<version>3.3.0</version>
<executions>
<!-- Prevent users from mistyping a profile name -->
<execution>
Expand All @@ -704,6 +677,26 @@
<goal>enforce</goal>
</goals>
</execution>
<execution>
<id>enforce-declared-grpc-and-proto-version</id>
<goals>
<goal>enforce</goal>
</goals>
<configuration>
<rules>
<bannedDependencies>
<includes>
<dependency>io.grpc:*:[${grpc.version}]</dependency>
<dependency>com.google.protobuf:*:[${protobuf.version}]</dependency>
</includes>
<excludes>
<dependency>io.grpc:*</dependency>
<dependency>com.google.protobuf:*</dependency>
</excludes>
</bannedDependencies>
</rules>
</configuration>
</execution>
</executions>
<!--
workaround for https://github.com/mojohaus/extra-enforcer-rules/issues/132
Expand Down