Skip to content

fix(test): fix flaky test #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 16, 2023
Merged

fix(test): fix flaky test #1633

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3d23de0
fix(test): fix flaky test
igorbernstein2 Feb 16, 2023
7266cb8
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 16, 2023
900906a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 16, 2023
05bb855
Merge branch 'fix-test' of https://github.com/googleapis/java-bigtabl…
gcf-owl-bot[bot] Feb 16, 2023
8c3eb76
missing import
igorbernstein2 Feb 16, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...able/src/test/java/com/google/cloud/bigtable/data/v2/stub/readrows/ReadRowsRetryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
import com.google.cloud.bigtable.data.v2.models.Range.ByteStringRange;
import com.google.cloud.bigtable.data.v2.models.Row;
import com.google.common.collect.Lists;
import com.google.common.collect.Queues;
import com.google.common.collect.Range;
import com.google.common.truth.Truth;
import com.google.protobuf.ByteString;
Expand All @@ -48,6 +47,7 @@
import java.io.IOException;
import java.util.List;
import java.util.Queue;
import java.util.concurrent.LinkedBlockingDeque;
import org.junit.After;
import org.junit.Before;
import org.junit.Rule;
Expand Down Expand Up @@ -300,7 +300,7 @@ private List<String> getResults(Query query) {
}

private static class TestBigtableService extends BigtableGrpc.BigtableImplBase {
Queue<RpcExpectation> expectations = Queues.newArrayDeque();
Queue<RpcExpectation> expectations = new LinkedBlockingDeque<>();
int i = -1;

@Override
Expand Down