fix: fix compatibility of CloudBigtableIO with the emulator env var #3940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There are 2 issues that prevented CloudBigtableIO from working with the emulator: 1. useBulk macro setting would override the endpoint to batch-bigtable.googleapis.com regardless if the BIGTABLE_EMULATOR_ENV was set 2. the emulator doesnt return sample row key sizes when when the data is tiny, so split calculations broke Change-Id: Ia550f9fb5402e847e5b6336c211019401fdd41f1
product-auto-label bot added size: xs 
igorbernstein2 added automerge 
gcf-owl-bot bot removed the owlbot:run igorbernstein2 added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
mutianf reviewed Jan 30, 2023
...parent/bigtable-hbase-beam/src/main/java/com/google/cloud/bigtable/beam/CloudBigtableIO.java Outdated Show resolved Hide resolved
igorbernstein2 removed the automerge Change-Id: Id8d62972424ebf4ece195d4cf643d90f8d03c1dd
igorbernstein2 added automerge gcf-owl-bot bot removed the owlbot:run 
gcf-merge-on-green bot removed the automerge 
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 31, 2023
🤖 I have created a release *beep* *boop* --- ## [2.7.1](https://togithub.com/googleapis/java-bigtable-hbase/compare/v2.7.0...v2.7.1) (2023-01-30) ### Bug Fixes * Fix compatibility of CloudBigtableIO with the emulator env var ([#3940](https://togithub.com/googleapis/java-bigtable-hbase/issues/3940)) ([76bb401](https://togithub.com/googleapis/java-bigtable-hbase/commit/76bb40119dc4b70f67ac5e892f440e84b92c7612)) ### Dependencies * Update dependency com.fasterxml.jackson.core:jackson-databind to v2.14.2 ([#3938](https://togithub.com/googleapis/java-bigtable-hbase/issues/3938)) ([714e147](https://togithub.com/googleapis/java-bigtable-hbase/commit/714e1472771695ba5287cdecb34ba7ac053c5e0f)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There are 2 issues that prevented CloudBigtableIO from working with the emulator: