deps: replace all transitive log4j deps with reload4j #3930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: l 
This breaks the previous assumption that bigtable-hbase doesn't change hbase's classpath. Fortunately due to the severity of the issue, all log4j deps have been removed from hbase1 and replaced with reload4j. The immediate impact is that if the enduser's application depended on log4j, there will now be duplicate log4j classes (from reload4j and the enduser's log4j)
igorbernstein2 force-pushed the log4j-transitive branch from 6ec7b19 to 85cbd59 Compare product-auto-label bot added size: m igorbernstein2 added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run 
kolea2 reviewed Jan 20, 2023
kolea2 approved these changes Jan 20, 2023
igorbernstein2 added automerge gcf-owl-bot bot removed the owlbot:run igorbernstein2 added kokoro:force-run gcf-owl-bot bot removed the owlbot:run 
yoshi-kokoro removed the kokoro:force-run igorbernstein2 added the kokoro:force-run yoshi-kokoro removed kokoro:force-run 
| Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
gcf-merge-on-green bot removed the automerge igorbernstein2 added the owlbot:run gcf-owl-bot bot removed the owlbot:run 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
note: this is currently rebased on top of #3929
This breaks the previous assumption that bigtable-hbase doesn't change hbase's classpath. Fortunately due to the severity of the issue, all log4j deps have been removed from hbase1 and replaced with reload4j. The immediate impact is that if the enduser's application depended on log4j, there will now be duplicate log4j classes (from reload4j and the enduser's log4j)