Skip to content

chore: remove deprecated method #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 18, 2020
Merged

chore: remove deprecated method #95

merged 5 commits into from
Jan 18, 2020

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Jan 10, 2020

Fixes #68
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@codecov
Copy link

codecov bot commented Jan 10, 2020 •
edited
Loading

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #95 +/- ## ========================================= Coverage 77.32% 77.32% Complexity 1108 1108 ========================================= Files 73 73 Lines 5915 5915 Branches 645 645 ========================================= Hits 4574 4574 Misses 1014 1014 Partials 327 327

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee4d1e...6693faf. Read the comment docs.
elharo
elharo suggested changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per semver removing a deprecated method requires a major version bump because it's backwards incompatible. I suspect that should be done in this PR.
@pmakani pmakani requested a review from elharo January 10, 2020 13:08
elharo
elharo suggested changes Jan 10, 2020
View reviewed changes
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/OptionTest.java Outdated
}

@Test
@Test(expected = NullPointerException.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google best practice is not to use expected exceptions. As of JUnit 4.13 you can use assertThrows instead.
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

Merging #95 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## master #95 +/- ## ============================================ - Coverage 77.32% 77.26% -0.06%  Complexity 1108 1108 ============================================ Files 73 73 Lines 5915 5904 -11 Branches 645 635 -10 ============================================ - Hits 4574 4562 -12  + Misses 1014 1011 -3  - Partials 327 331 +4
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/google/cloud/bigquery/BigQuery.java 77.15% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 66.95% <ø> (-0.06%) 58 <0> (ø)
...ogle/cloud/bigquery/WriteChannelConfiguration.java 85.5% <0%> (-0.62%) 44% <0%> (ø)
...om/google/cloud/bigquery/LoadJobConfiguration.java 89.68% <0%> (-0.48%) 52% <0%> (ø)
...google/cloud/bigquery/StandardTableDefinition.java 86.36% <0%> (-0.41%) 14% <0%> (ø)
...a/com/google/cloud/bigquery/InsertAllResponse.java 88.88% <0%> (-0.31%) 15% <0%> (ø)
...m/google/cloud/bigquery/QueryJobConfiguration.java 76.85% <0%> (-0.29%) 56% <0%> (ø)
...src/main/java/com/google/cloud/bigquery/Field.java 82.6% <0%> (-0.19%) 25% <0%> (ø)
.../google/cloud/bigquery/spi/v2/HttpBigQueryRpc.java 5.24% <0%> (+0.03%) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee4d1e...ba393aa. Read the comment docs.
@athakor athakor added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 16, 2020
elharo
elharo suggested changes Jan 16, 2020
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't change the public API without a major version bump.
@pmakani pmakani requested a review from elharo January 16, 2020 12:41
elharo
elharo reviewed Jan 16, 2020
View reviewed changes
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/OptionTest.java Outdated
try {
new Option(null, VALUE) {};
Assert.fail();
} catch (NullPointerException ex) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ex --> expected in this pattern, to avoid problems with static code analysis
google-cloud-bigquery/src/test/java/com/google/cloud/bigquery/OptionTest.java Outdated
new Option(null, VALUE) {};
Assert.fail();
} catch (NullPointerException ex) {
assertNull(ex.getMessage());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this is current behavior, but there should be a message here and I'd prefer not to lock in its nonexistence with this assert.
@pmakani pmakani merged commit eab8f27 into googleapis:master Jan 18, 2020
@pmakani pmakani deleted the bigquery-68 branch January 18, 2020 04:56
@stephaniewang526 stephaniewang526 mentioned this pull request Jan 18, 2020
Closed
@yoshi-automation yoshi-automation mentioned this pull request Jan 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

5 participants

@pmakani @elharo @googlebot @yoshi-kokoro @athakor