- Notifications
You must be signed in to change notification settings - Fork 128
feat: update samples #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stephaniewang526 merged 15 commits into googleapis:master from stephaniewang526:feat-samples Dec 24, 2019
Merged
feat: update samples #52
stephaniewang526 merged 15 commits into googleapis:master from stephaniewang526:feat-samples Dec 24, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Resolve merge conflicts # Conflicts: # samples/src/main/java/com/example/bigquery/CreateTable.java # samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java # samples/src/test/java/com/example/bigquery/CreateTableIT.java # samples/src/test/java/com/example/bigquery/ExtractTableToJSONIT.java
Codecov Report
@@ Coverage Diff @@ ## master #52 +/- ## ========================================= Coverage 77.32% 77.32% Complexity 1108 1108 ========================================= Files 73 73 Lines 5915 5915 Branches 645 645 ========================================= Hits 4574 4574 Misses 1014 1014 Partials 327 327Continue to review full report at Codecov.
|
kurtisvg suggested changes Dec 20, 2019
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
kurtisvg suggested changes Dec 23, 2019
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
samples/src/test/java/com/example/bigquery/ExtractTableToJSONIT.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJSON.java Outdated Show resolved Hide resolved
kurtisvg suggested changes Dec 23, 2019
samples/src/main/java/com/example/bigquery/ExtractTableToJson.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJson.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJson.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJson.java Outdated Show resolved Hide resolved
samples/src/main/java/com/example/bigquery/ExtractTableToJson.java Outdated Show resolved Hide resolved
samples/src/test/java/com/example/bigquery/ExtractTableToJsonIT.java Outdated Show resolved Hide resolved
kurtisvg suggested changes Dec 24, 2019
samples/src/main/java/com/example/bigquery/ExtractTableToJson.java Outdated Show resolved Hide resolved
kurtisvg approved these changes Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
follow up PR of #44