docs(samples): add auth user flow and query #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
googlebot added the cla: yes 
Codecov Report
@@ Coverage Diff @@ ## master #478 +/- ## ============================================ - Coverage 81.49% 81.35% -0.15% Complexity 1226 1226 ============================================ Files 77 77 Lines 6220 6220 Branches 691 685 -6 ============================================ - Hits 5069 5060 -9 - Misses 792 797 +5 - Partials 359 363 +4
Continue to review full report at Codecov.
|
stephaniewang526 suggested changes Jul 3, 2020
| @Test | ||
| public void testAuthUserFlow() { | ||
| // TODO(stephaniewang526): Replace client_secret.json | ||
| /*File credentialsPath = new File(""path/to/your/client_secret.json"); |
There was a problem hiding this comment.
we cannot upload any files that contains secrets -- have to use GCS
String sourceUri = "gs://cloud-devrel-kokoro-resources/java-docs-samples/service-acct.json"; so we have to figure out how to generate File from gcs path.
stephaniewang526 suggested changes Jul 3, 2020
stephaniewang526 added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run stephaniewang526 approved these changes Jul 6, 2020
| selectedScopes) | ||
| .setDataStoreFactory(new FileDataStoreFactory(DATA_STORE_DIR)) | ||
| .setAccessType("offline") | ||
| .setApprovalPrompt("force") |
There was a problem hiding this comment.
change to "auto" so user does not need to manually confirm
stephaniewang526 added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
pmakani added kokoro:force-run stephaniewang526 added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
| since we cannot manually approve approval prompt, we should try to do mock testing instead here. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: