feat: Relax client-side validation for BigQuery entity IDs #4000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: s 
jinseopkim0 force-pushed the fix-client-validation branch from b57a1f5 to 2190847 Compare 
Removes client-side `checkArgument` and `checkNotNull` validations from the constructors of `TableId`, `DatasetId`, `RoutineId`, `ModelId`, and `ConnectionProperty`. This change makes the client library more robust by preventing crashes when the server sends a response with unexpected null or empty values in these fields.
jinseopkim0 force-pushed the fix-client-validation branch from 2190847 to db46518 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Removes client-side
checkArgumentandcheckNotNullvalidations from the constructors ofTableId,DatasetId,RoutineId,ModelId, andConnectionProperty.This change makes the client library more robust by preventing crashes when the server sends a response with unexpected null or empty values in these fields.
b/460218010