Skip to content

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented May 1, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #296

@pmakani pmakani requested a review from stephaniewang526 May 1, 2020 05:23
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2020
@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #305 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## master #305 +/- ## ============================================ - Coverage 77.59% 77.56% -0.03%  Complexity 1158 1158 ============================================ Files 76 76 Lines 6110 6103 -7 Branches 656 656 ============================================ - Hits 4741 4734 -7  Misses 1020 1020 Partials 349 349 
Impacted Files Coverage Δ Complexity Δ
...google/cloud/bigquery/StandardTableDefinition.java 93.05% <ø> (-0.62%) 16.00 <0.00> (ø)
...va/com/google/cloud/bigquery/TimePartitioning.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b539f95...aebc345. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 6315842 into googleapis:master May 1, 2020
@pmakani pmakani deleted the bigquery-timepartition-296 branch May 4, 2020 10:53
gcf-merge-on-green bot pushed a commit that referenced this pull request May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

3 participants