Skip to content

Conversation

stephaniewang526
Copy link
Contributor

@stephaniewang526 stephaniewang526 commented Jan 18, 2022

Fixes b/213373577

cc @nageshs

@stephaniewang526 stephaniewang526 requested review from a team and tswast January 18, 2022 18:41
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/java-bigquery API. label Jan 18, 2022
@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 19, 2022
Copy link

@nageshs nageshs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a first pass, but agreed with @nageshs that supporting the built-in javax.json.JsonObject type (automatically converting to string for the user) in addition to String would be desirable.

@stephaniewang526 stephaniewang526 requested a review from a team as a code owner January 26, 2022 23:03
Copy link

@nageshs nageshs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great to me.

@stephaniewang526 stephaniewang526 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 27, 2022
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure LGTM, but I have some worries about the new dependency.

@stephaniewang526 stephaniewang526 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 27, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 73c4a73 into googleapis:main Jan 27, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 27, 2022
gcf-merge-on-green bot pushed a commit that referenced this pull request Jan 27, 2022
🤖 I have created a release *beep* *boop* --- ## [2.7.0](v2.6.2...v2.7.0) (2022-01-27) ### Features * add JSON type support ([#1799](#1799)) ([73c4a73](73c4a73)) ### Dependencies * **java:** update actions/github-script action to v5 ([#1339](#1339)) ([#1809](#1809)) ([90afea5](90afea5)) * update actions/github-script action to v5 ([#1808](#1808)) ([8e5f585](8e5f585)) * update dependency com.google.cloud:google-cloud-storage to v2.3.0 ([#1796](#1796)) ([8b77d9b](8b77d9b)) * update dependency com.google.oauth-client:google-oauth-client-java6 to v1.33.0 ([#1802](#1802)) ([c78fc77](c78fc77)) * update dependency com.google.oauth-client:google-oauth-client-jetty to v1.33.0 ([#1803](#1803)) ([8e34e59](8e34e59)) * update dependency org.assertj:assertj-core to v3 ([#1786](#1786)) ([69fcabf](69fcabf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
gcf-owl-bot bot added a commit that referenced this pull request May 19, 2023
Source-Link: googleapis/synthtool@1fd6dff Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ad9cabee4c022f1aab04a71332369e0c23841062124818a4490f73337f790337
suztomo pushed a commit that referenced this pull request May 19, 2023
Source-Link: googleapis/synthtool@1fd6dff Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:ad9cabee4c022f1aab04a71332369e0c23841062124818a4490f73337f790337 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/java-bigquery API.

3 participants